-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: upgrade chai to 5.x #4628
Conversation
🦋 Changeset detectedLatest commit: 9b9fd49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes and tests look good!
Just needs an empty changeset file to pass CI checks.
have removed any empty let me know if that works (particularly the changeset, haven't done an empty one before) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! ✨
Upgrades chai to the latest version (5.x) which now ships as ESM directly, meaning we no longer need esm-bundle's fork.
i've rebased onto main and upgraded in the rollup plugin that got added to labs too FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @43081j!
I'm ready to do this now. There are a few things I don't like about uvu, and node:test works really well.
That's just due to browser and Node tests. We'll have a mixture of node:test and chai in the future. |
Upgrades chai to the latest version (5.x) which now ships as ESM directly, meaning we no longer need esm-bundle's fork.
we may want to use node's built in test runner and assertion library for non-browser tests some day,
i also noticed we now have a mixture of
uvu
andchai
- maybe we want to settle on one some day 🤔